Issue 200783007: Extract item<->index conversion from iterator into a separate interface

Issue 200783007: Extract item<->index conversion from iterator into a separate interface (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Extract item<->index conversion from iterator into a separate interface BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169832

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -104 lines)			Patch
	M	Source/devtools/front_end/HeapSnapshot.js	View	1	15 chunks	+135 lines, -104 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm Consider unifying getter name to just "index" for all three item types, so you ...

6 years, 9 months ago (2014-03-21 15:11:27 UTC) #2

yurys

https://codereview.chromium.org/200783007/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/200783007/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode733 Source/devtools/front_end/HeapSnapshot.js:733: WebInspector.HeapSnapshotIndexRangeIterator = function(indexProvider, indexes) On 2014/03/21 15:11:27, alph wrote: ...

6 years, 9 months ago (2014-03-24 06:10:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/200783007/40001

6 years, 9 months ago (2014-03-24 06:17:31 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-24 06:18:32 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on mac_blink_rel

6 years, 9 months ago (2014-03-24 06:18:32 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/200783007/40001

6 years, 9 months ago (2014-03-24 06:22:52 UTC) #9

Message was sent while issue was closed.

Change committed as 169832

Expand Messages | Collapse Messages