[OriginChip] Add animations for the hiding and showing of the chip.

chrome/browser/ui/omnibox/omnibox_edit_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_edit_controller.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
+#include "chrome/browser/ui/toolbar/toolbar_model.h"
 
 void OmniboxEditController::OnAutocompleteAccept(
     const GURL& destination_url,
     WindowOpenDisposition disposition,
     content::PageTransition transition) {
   destination_url_ = destination_url;
   disposition_ = disposition;
   transition_ = transition;
   if (command_updater_)
     command_updater_->ExecuteCommand(IDC_OPEN_CURRENT_URL);
 }
 
 OmniboxEditController::OmniboxEditController(CommandUpdater* command_updater)
     : command_updater_(command_updater),
       disposition_(CURRENT_TAB),
       transition_(content::PageTransitionFromInt(
           content::PAGE_TRANSITION_TYPED |
           content::PAGE_TRANSITION_FROM_ADDRESS_BAR)) {
 }
 
+void OmniboxEditController::HideOriginChip() {
+  GetToolbarModel()->set_origin_chip_enabled(false);
+  OnChanged();
+}
+
+void OmniboxEditController::ShowOriginChip() {
+  if (GetToolbarModel()->url_replacement_enabled()) {

[Peter Kasting, 2014/03/21 21:22:10]

I'm not really clear on what this conditional is doing?  I didn't see it in the
old version of OmniboxView::HandleOriginChipMouseRelease().

[Justin Donnelly, 2014/03/24 22:59:37]

This handles the two states we end up in after either clicking the origin chip
or clicking in the omnibox.  Only the former sets url_replacement_enabled to
false.

Previously I was performing all the steps required for the chip-click case to
avoid checking which was necessary (see [1]).  I preferred that because it
seemed simpler but with the animations we need to distinguish between these two
cases.

Added a comment to clarify.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

+    GetToolbarModel()->set_origin_chip_enabled(true);
+    OnChanged();
+  } else {
+    HideURL();
+  }
+}
+
 OmniboxEditController::~OmniboxEditController() {
 }