Gamepad API: add support for gamepadconnected and gamepaddisconnected events

Source/modules/gamepad/NavigatorGamepad.h

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  * DAMAGE.
  */
 
 #ifndef NavigatorGamepad_h
 #define NavigatorGamepad_h
 
+#include "core/frame/DOMWindowLifecycleObserver.h"
+#include "core/frame/DOMWindowProperty.h"
 #include "heap/Handle.h"
 #include "platform/Supplementable.h"
 #include "public/platform/WebGamepads.h"
 
 namespace WebCore {
 
 class GamepadList;
 class Navigator;
 class WebKitGamepadList;
 
-class NavigatorGamepad FINAL : public Supplement<Navigator> {
+class NavigatorGamepad FINAL : public Supplement<Navigator>, public DOMWindowProperty, public blink::WebGamepadListener, public DOMWindowLifecycleObserver {

[abarth-chromium, 2014/03/17 18:23:46]

You shouldn't need both DOMWindowProperty and DOMWindowLifecycleObserver. 
DOMWindowProperty already gives you all the lifecycle observations you should
need.

[kbalazs, 2014/03/17 23:49:27]

I don't need both indeed. I want to start listening from the time when
addWindowListener is used. This is to not ask the browser process to start the
gamepad code before it is needed because it has a cost (creating the polling
thread). So I kept the inheritance from DOMWindowLifecycleObserver and removed
DOMWindowProperty.

 public:
     virtual ~NavigatorGamepad();
     static NavigatorGamepad& from(Navigator&);
 
     static WebKitGamepadList* webkitGetGamepads(Navigator&);
     static GamepadList* getGamepads(Navigator&);
 
     WebKitGamepadList* webkitGamepads();
     GamepadList* gamepads();
 
+    virtual void onGamepadConnected(unsigned index, const blink::WebGamepad&) OVERRIDE;
+    virtual void onGamepadDisconnected(unsigned index, const blink::WebGamepad&) OVERRIDE;

[abarth-chromium, 2014/03/17 18:23:46]

We use Obj-C style names:

didConnectGamepad
willDisconnectGamepad

(whichever is appropriate)

[kbalazs, 2014/03/17 23:49:27]

Changed to didConnectGamepad and didDisconnectGamepad.

+
+    virtual void didAddEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
+
 private:
-    NavigatorGamepad();
+    explicit NavigatorGamepad(LocalFrame*);
     static const char* supplementName();
 
     RefPtrWillBePersistent<GamepadList> m_gamepads;
     RefPtrWillBePersistent<WebKitGamepadList> m_webkitGamepads;
 };
 
 } // namespace WebCore
 
 #endif // NavigatorGamepad_h