Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007813004: Mojo C++ bindings: support attaching context object for StructTraits. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: support attaching context object for StructTraits. This CL also updates the documentation of StructTraits. BUG=577686 Committed: https://crrev.com/6990a00a7dad6f2754e65014fe98230deaa1a88c Cr-Commit-Position: refs/heads/master@{#395720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -21 lines) Patch
M mojo/public/cpp/bindings/lib/serialization_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/struct_traits.h View 2 chunks +31 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h View 1 chunk +7 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-24 21:12:31 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-24 21:28:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007813004/1
4 years, 7 months ago (2016-05-24 21:35:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 23:00:27 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 23:02:30 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6990a00a7dad6f2754e65014fe98230deaa1a88c
Cr-Commit-Position: refs/heads/master@{#395720}

Powered by Google App Engine
This is Rietveld 408576698