appengine/findit/waterfall/build_util.py - Issue 2007783003: [Findit] Make sure build data is updated when use build master.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_util.py

Issue 2007783003: [Findit] Make sure build data is updated when use build master. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/build_util.py

diff --git a/appengine/findit/waterfall/build_util.py b/appengine/findit/waterfall/build_util.py

index 8a4ff92d9fe585590bc97b8ce2abfc53c3b3088d..362f6114eff9caea10cde03413dae7bcf8ef85e1 100644

--- a/appengine/findit/waterfall/build_util.py

+++ b/appengine/findit/waterfall/build_util.py

@@ -45,7 +45,7 @@ def DownloadBuildData(master_name, builder_name, build_number):

master_name): # pragma: no cover

return None

- if not build.data:

+ if not build.data or not use_cbe:

# Retrieve build data from build master.

build.data = buildbot.GetBuildDataFromBuildMaster(

master_name, builder_name, build_number, HTTP_CLIENT_LOGGING_ERRORS)

« no previous file with comments | « no previous file | appengine/findit/waterfall/test/build_util_test.py » ('j') | no next file with comments »