Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007753003: Make Sk32ToBool inline again to silence compiler warning. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Sk32ToBool inline again to silence compiler warning. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2007753003 Committed: https://skia.googlesource.com/skia/+/7a5bcc5f59bdf122217bc8ca7e756e8c76bae9e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkTypes.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2006383002 Patch 1

Messages

Total messages: 9 (4 generated)
bsalomon
This shouldn't be necessary but for some reason my CLion/cmake builds give an unused function ...
4 years, 7 months ago (2016-05-24 19:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007753003/1
4 years, 7 months ago (2016-05-24 19:42:09 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-24 19:42:10 UTC) #6
hal.canary
lgtm
4 years, 7 months ago (2016-05-24 19:46:32 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:24:00 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a5bcc5f59bdf122217bc8ca7e756e8c76bae9e1

Powered by Google App Engine
This is Rietveld 408576698