MD User Manager: Fixes remove profile button for languages with long texts

MD User Manager: Fixes remove profile button for languages with long texts

BUG=563722, 452001
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aeb51251a1940448255c34563f5675d4be7263a2
Cr-Commit-Position: refs/heads/master@{#396234}

[Moe, 2016-05-24 14:45:06]

Description was changed from

==========
MD User Manager: Fixes remove profile button for languages with long texts

BUG=563722, 452001
==========

to

==========
MD User Manager: Fixes remove profile button for languages with long texts

BUG=563722, 452001
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-05-24 19:09:12]

mahmadi@chromium.org changed reviewers:
+ dpapad@chromium.org

[Moe, 2016-05-24 19:09:13]

Demetrios, Please review this CL.

after screenshot: http://imgur.com/IbclAPn

[dpapad, 2016-05-24 22:47:32]

On 2016/05/24 at 19:09:13, mahmadi wrote:
> Demetrios, Please review this CL.
> 
> after screenshot: http://imgur.com/IbclAPn

I had filed a bug about making text inside a paper-button centered vertically by
default a
 https://github.com/PolymerElements/paper-button/issues/113. This bug was fixed
yesterday 
with commit
https://github.com/PolymerElements/paper-button/commit/dddb83469d381df84766b0...
and is now available at paper-button v1.0.12. There is a comment on this commit
about some breakages, so not
sure if this will get reverted, but it seems to me that we should wait until the
situation clears out with that fix,
since next Polymer roll might make this CL obsolete. WDYT?

[Moe, 2016-05-25 13:58:30]

On 2016/05/24 22:47:32, dpapad wrote:
> On 2016/05/24 at 19:09:13, mahmadi wrote:
> > Demetrios, Please review this CL.
> > 
> > after screenshot: http://imgur.com/IbclAPn
> 
> I had filed a bug about making text inside a paper-button centered vertically
by
> default a
>  https://github.com/PolymerElements/paper-button/issues/113. This bug was
fixed
> yesterday 
> with commit
>
https://github.com/PolymerElements/paper-button/commit/dddb83469d381df84766b0...
> and is now available at paper-button v1.0.12. There is a comment on this
commit
> about some breakages, so not
> sure if this will get reverted, but it seems to me that we should wait until
the
> situation clears out with that fix,
> since next Polymer roll might make this CL obsolete. WDYT?

Thanks for sharing this fix with me! I don't think it would make this CL
obsolete though. Besides correctly positioning the button inside its parent
container, it also refactors the style for the action buttons into a new mixin.

side note, although I think the fix would make the default state of paper-button
more useful, I prefer to give explicit line-height + padding-top/bottom to
buttons rather than an explicit height for the sake of long i18n text. WDYT?

[dpapad, 2016-05-25 17:16:31]

On 2016/05/25 at 13:58:30, mahmadi wrote:
> On 2016/05/24 22:47:32, dpapad wrote:
> > On 2016/05/24 at 19:09:13, mahmadi wrote:
> > > Demetrios, Please review this CL.
> > > 
> > > after screenshot: http://imgur.com/IbclAPn
> > 
> > I had filed a bug about making text inside a paper-button centered
vertically by
> > default a
> >  https://github.com/PolymerElements/paper-button/issues/113. This bug was
fixed
> > yesterday 
> > with commit
> >
https://github.com/PolymerElements/paper-button/commit/dddb83469d381df84766b0...
> > and is now available at paper-button v1.0.12. There is a comment on this
commit
> > about some breakages, so not
> > sure if this will get reverted, but it seems to me that we should wait until
the
> > situation clears out with that fix,
> > since next Polymer roll might make this CL obsolete. WDYT?
> 
> Thanks for sharing this fix with me! I don't think it would make this CL
obsolete though. Besides correctly positioning the button inside its parent
container, it also refactors the style for the action buttons into a new mixin.
> 
> side note, although I think the fix would make the default state of
paper-button more useful, I prefer to give explicit line-height +
padding-top/bottom to buttons rather than an explicit height for the sake of
long i18n text. WDYT?

LGTM.
I guess line-height + padding-top/bottom is more robust to arbitrarily long
strings. IIUC the only thing that would be unnecessary if the paper-button fix
sticks, would be the "align-self: center;" rule.

[Moe, 2016-05-26 17:25:43]

I replaced 'align-self: center;' with 'align-items: center;' on its parent
container. otherwise, the button gets stretched and fills the entire width.

Thank you!

[Moe, 2016-05-26 17:27:53]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-05-26 17:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2007743004/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-05-26 17:28:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007743004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007743004/20001

[commit-bot: I haz the power, 2016-05-26 18:26:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 18:29:23]

Description was changed from

==========
MD User Manager: Fixes remove profile button for languages with long texts

BUG=563722, 452001
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD User Manager: Fixes remove profile button for languages with long texts

BUG=563722, 452001
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aeb51251a1940448255c34563f5675d4be7263a2
Cr-Commit-Position: refs/heads/master@{#396234}
==========

[commit-bot: I haz the power, 2016-05-26 18:29:24]

Patchset 2 (id:??) landed as
https://crrev.com/aeb51251a1940448255c34563f5675d4be7263a2
Cr-Commit-Position: refs/heads/master@{#396234}