Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2007743004: MD User Manager: Fixes remove profile button for languages with long texts (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Fixes remove profile button for languages with long texts BUG=563722, 452001 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aeb51251a1940448255c34563f5675d4be7263a2 Cr-Commit-Position: refs/heads/master@{#396234}

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/resources/md_user_manager/shared_styles.html View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_styles.html View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Moe
Demetrios, Please review this CL. after screenshot: http://imgur.com/IbclAPn
4 years, 7 months ago (2016-05-24 19:09:13 UTC) #3
dpapad
On 2016/05/24 at 19:09:13, mahmadi wrote: > Demetrios, Please review this CL. > > after ...
4 years, 7 months ago (2016-05-24 22:47:32 UTC) #4
Moe
On 2016/05/24 22:47:32, dpapad wrote: > On 2016/05/24 at 19:09:13, mahmadi wrote: > > Demetrios, ...
4 years, 7 months ago (2016-05-25 13:58:30 UTC) #5
dpapad
On 2016/05/25 at 13:58:30, mahmadi wrote: > On 2016/05/24 22:47:32, dpapad wrote: > > On ...
4 years, 7 months ago (2016-05-25 17:16:31 UTC) #6
Moe
I replaced 'align-self: center;' with 'align-items: center;' on its parent container. otherwise, the button gets ...
4 years, 7 months ago (2016-05-26 17:25:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007743004/20001
4 years, 7 months ago (2016-05-26 17:28:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 18:26:46 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:29:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aeb51251a1940448255c34563f5675d4be7263a2
Cr-Commit-Position: refs/heads/master@{#396234}

Powered by Google App Engine
This is Rietveld 408576698