webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc - Issue 2007743003: Add sender controlled playout delay limits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc

Issue 2007743003: Add sender controlled playout delay limits (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@cleanup_rtp_hdr_extensions

Patch Set: Addressed nits and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/config.cc ('K') | « webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_header_extension.h » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc

index 34b2ce3687f4f442787ea5c27d1ccd7ea006c86b..17a21d908e050e7c1838d01bd159a0ef4ff44acc 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc

@@ -1356,6 +1356,12 @@ void RTCPReceiver::TriggerCallbacksFromRTCPPacket(

now);

}

+ if ((rtcpPacketInformation.rtcpPacketTypeFlags & kRtcpSr) ||

+ (rtcpPacketInformation.rtcpPacketTypeFlags & kRtcpRr)) {

+ _rtpRtcp.OnReceivedRtcpReceiverReport(

stefan-webrtc 2016/06/06 14:08:15 This sounds a bit wrong to me. Should it be OnRece

Irfan 2016/06/06 15:39:41 The current implementation seems to indicate the S

stefan-webrtc 2016/06/06 20:02:25 Ack, I'd prefer OnReceivedReportBlocks, especially

+ rtcpPacketInformation.report_blocks);

+ }

if (_cbTransportFeedbackObserver &&

(rtcpPacketInformation.rtcpPacketTypeFlags & kRtcpTransportFeedback)) {

uint32_t media_source_ssrc =