Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: webrtc/common_types.h

Issue 2007743003: Add sender controlled playout delay limits (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@cleanup_rtp_hdr_extensions
Patch Set: Removed audio changes and added locking on playout delay oracle Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/common_types.cc » ('j') | webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index 587b90d753ce3f3eb092dfd01edb8b1b68303719..e133e0be9c600a19ae9c797bee57db73b3d38f2a 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -751,6 +751,21 @@ struct PacketTime {
// If unknown, this value will be set to zero.
};
+// Minimum and maximum playout delay values from capture to render.
+// These are best effort values.
+//
+// A value < 0 indicates no change from previous valid value.
+//
+// min = max = 0 indicates that the receiver should try and render
+// frame as soon as possible.
+//
+// min = x, max = y indicates that the receiver is free to adapt
+// in the range (x, y) based on network jitter.
+struct PlayoutDelay {
danilchap 2016/05/26 09:41:58 May be you want to add a default constructor and i
Sergey Ulanov 2016/05/30 07:22:56 Or just add default initalizers '= -1' in the fiel
Irfan 2016/06/01 08:38:33 I have added a comment here, but this eventually e
+ int min_ms;
+ int max_ms;
+};
+
struct RTPHeaderExtension {
RTPHeaderExtension();
@@ -772,6 +787,8 @@ struct RTPHeaderExtension {
// ts_126114v120700p.pdf
bool hasVideoRotation;
uint8_t videoRotation;
+
+ PlayoutDelay playout_delay;
};
struct RTPHeader {
« no previous file with comments | « no previous file | webrtc/common_types.cc » ('j') | webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698