MD Settings: About page, display product info.

MD Settings: About page, display product info.

BUG=546841, 603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/579707b053f21e5d018284238b512d13658290fb
Cr-Commit-Position: refs/heads/master@{#395527}

[dpapad, 2016-05-23 21:33:26]

Description was changed from

==========
MD Settings: About page, include product info.

BUG=546841,603625
==========

to

==========
MD Settings: About page, include product info.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-23 22:51:39]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-05-23 22:51:40]

Screenshots at http://imgur.com/a/grus0.

[dpapad, 2016-05-23 22:52:17]

Description was changed from

==========
MD Settings: About page, include product info.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, display product info.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-24 00:06:51]

On 2016/05/23 22:51:40, dpapad wrote:
> Screenshots at http://imgur.com/a/grus0.

There is some extra vertical space in the mock
between some lines. Should they be part of
this CL?

[dpapad, 2016-05-24 00:31:10]

On 2016/05/24 at 00:06:51, dschuyler wrote:
> On 2016/05/23 22:51:40, dpapad wrote:
> > Screenshots at http://imgur.com/a/grus0.
> 
> There is some extra vertical space in the mock
> between some lines. Should they be part of
> this CL?

Done, see http://imgur.com/a/BKtFH.

[dschuyler, 2016-05-24 00:40:23]

LGTM with another spacing nit.

https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:115: <div
class="info-section">
nit: the top padding on this div
makes the screen shot look like there
is too much padding on the top. Does it look ok
to remove this <div class="info-section">
and rely only on the .inf-section below
for spacing?

[dpapad, 2016-05-24 00:49:10]

https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:115: <div
class="info-section">
On 2016/05/24 at 00:40:23, dschuyler wrote:
> nit: the top padding on this div
> makes the screen shot look like there
> is too much padding on the top. Does it look ok
> to remove this <div class="info-section">
> and rely only on the .inf-section below
> for spacing?

You are right. I fixed it by specifying padding-bottom only instead of both
padding top and bottom.

[dpapad, 2016-05-24 00:55:03]

On 2016/05/24 at 00:49:10, dpapad wrote:
>
https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/about_page/about_page.html (right):
> 
>
https://codereview.chromium.org/2007733002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/about_page/about_page.html:115: <div
class="info-section">
> On 2016/05/24 at 00:40:23, dschuyler wrote:
> > nit: the top padding on this div
> > makes the screen shot look like there
> > is too much padding on the top. Does it look ok
> > to remove this <div class="info-section">
> > and rely only on the .inf-section below
> > for spacing?
> 
> You are right. I fixed it by specifying padding-bottom only instead of both
padding top and bottom.

I meant margin, not padding.

[dpapad, 2016-05-24 01:24:31]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-05-24 01:24:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2007733002/#ps40001
(title: "Remove top margin.")

[commit-bot: I haz the power, 2016-05-24 01:24:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007733002/40001

[commit-bot: I haz the power, 2016-05-24 03:45:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 03:47:05]

Description was changed from

==========
MD Settings: About page, display product info.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, display product info.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/579707b053f21e5d018284238b512d13658290fb
Cr-Commit-Position: refs/heads/master@{#395527}
==========

[commit-bot: I haz the power, 2016-05-24 03:47:07]

Patchset 3 (id:??) landed as
https://crrev.com/579707b053f21e5d018284238b512d13658290fb
Cr-Commit-Position: refs/heads/master@{#395527}