Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2007723002: Declare methods defined in LayoutObjectInlines.h as inline. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Declare methods defined in LayoutObjectInlines.h as inline. This way we'll detect a failure to include LayoutObjectInlines.h during compilation, rather than during linking. Test case: Remove inclusion of LayoutObjectInlines.h from LayoutBR.cpp. See https://codereview.chromium.org/2008503003/ - I initially tried to simply remove LayoutView.h from LayoutBR.cpp's include list, but got "strange" linker errors in release builds, since the compiler thought styleRef(bool) was an actual function, and not an inline. BUG=614015 Committed: https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306 Cr-Commit-Position: refs/heads/master@{#395558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-24 08:09:06 UTC) #3
davve
lgtm
4 years, 7 months ago (2016-05-24 08:19:15 UTC) #4
davve
Add BUG=614015 to description?
4 years, 7 months ago (2016-05-24 08:20:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007723002/1
4 years, 7 months ago (2016-05-24 09:17:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 09:53:11 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 09:55:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306
Cr-Commit-Position: refs/heads/master@{#395558}

Powered by Google App Engine
This is Rietveld 408576698