Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007673004: Move BackgroundBleedAvoidance definition to a separate file. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BackgroundBleedAvoidance definition to a separate file. This way BoxDecorationData.h doesn't need to include LayoutBoxModelObject.h BUG=614015 Committed: https://crrev.com/0491b3a72d1536cd424dd9b6e343ee203485bd2f Cr-Commit-Position: refs/heads/master@{#395745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
A third_party/WebKit/Source/core/layout/BackgroundBleedAvoidance.h View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxDecorationData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-24 21:21:59 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-24 21:25:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007673004/1
4 years, 7 months ago (2016-05-24 21:25:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 00:06:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:08:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0491b3a72d1536cd424dd9b6e343ee203485bd2f
Cr-Commit-Position: refs/heads/master@{#395745}

Powered by Google App Engine
This is Rietveld 408576698