Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 200763013: Directly modify version file on trunk branch in push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Directly modify version file on trunk branch in push-to-trunk. - This also shifts the push revision by one to prepare for the deprecation of the prepare push commit - The version increment is still based on the bleeding_edge version.cc. This will be changed in a follow up CL. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20054

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M tools/push-to-trunk/push_to_trunk.py View 5 chunks +10 lines, -3 lines 1 comment Download
M tools/push-to-trunk/test_scripts.py View 10 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-18 15:18:48 UTC) #1
Jakob Kummerow
LGTM https://codereview.chromium.org/200763013/diff/1/tools/push-to-trunk/push_to_trunk.py File tools/push-to-trunk/push_to_trunk.py (left): https://codereview.chromium.org/200763013/diff/1/tools/push-to-trunk/push_to_trunk.py#oldcode341 tools/push-to-trunk/push_to_trunk.py:341: self.GitAdd(self.Config(VERSION_FILE)) Are you sure we don't need this ...
6 years, 9 months ago (2014-03-19 10:24:08 UTC) #2
Michael Achenbach
On 2014/03/19 10:24:08, Jakob wrote: > LGTM > > https://codereview.chromium.org/200763013/diff/1/tools/push-to-trunk/push_to_trunk.py > File tools/push-to-trunk/push_to_trunk.py (left): > ...
6 years, 9 months ago (2014-03-19 10:43:33 UTC) #3
Michael Achenbach
6 years, 9 months ago (2014-03-19 10:46:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698