Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 200763012: Remove Promise.cast (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, yhirano
Visibility:
Public.

Description

Remove Promise.cast ...as per January meeting. Renames 'cast' to 'resolve'. We rename the prior 'resolve' to 'accept', to keep the chain API usable. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -103 lines) Patch
M src/promise.js View 4 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/es6/promises.js View 44 chunks +93 lines, -93 lines 0 comments Download
M test/webkit/fast/js/Promise-static-cast.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/webkit/fast/js/Promise-static-cast-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
lgtm
6 years, 9 months ago (2014-03-18 14:48:12 UTC) #1
rossberg
6 years, 9 months ago (2014-03-18 15:03:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r20040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698