content/renderer/media/webmediaplayer_impl.cc - Issue 200763011: Add explicit flush after copyTextureCHROMIUM to make the change visible accross contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 200763011: Add explicit flush after copyTextureCHROMIUM to make the change visible accross contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('K') | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index 9399476dd837e07a3435c0bdfebf7ced6fb91742..b3ea6def86b7322c9f0c55bbc92ea6a0accea502 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -680,9 +680,6 @@ bool WebMediaPlayerImpl::copyVideoTextureToPlatformTexture(

web_graphics_context->bindTexture(GL_TEXTURE_2D, texture);

web_graphics_context->deleteTexture(source_texture);

- // The flush() operation is not necessary here. It is kept since the

- // performance will be better when it is added than not.

no sievers 2014/03/19 17:02:19 Why remove this comment though? Does it not apply

junj 2014/03/20 02:39:34 The performance(FPS) seems still better on win7 wi

web_graphics_context->flush();

return true;

}