Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 200763008: Remove NoInterfaceObject from BatteryManager. (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove NoInterfaceObject from BatteryManager. This flag has been removed from newer versions of the specification. BUG=353337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169459

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/battery/BatteryManager.idl View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mlamouri (slow - plz ping)
6 years, 9 months ago (2014-03-17 22:46:15 UTC) #1
abarth-chromium
LGTM Seems a bit odd, but ok.
6 years, 9 months ago (2014-03-18 00:29:00 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-18 10:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/200763008/1
6 years, 9 months ago (2014-03-18 10:19:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 10:49:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 10:49:28 UTC) #6
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-18 16:23:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/200763008/20001
6 years, 9 months ago (2014-03-18 16:23:55 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 18:57:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 169459

Powered by Google App Engine
This is Rietveld 408576698