LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml - Issue 200763006: Node::setTextContent should avoid work when nothing changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

Issue 200763006: Node::setTextContent should avoid work when nothing changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated beforeload-set-text-crash to not timeout Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

diff --git a/LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml b/LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

index 5fd55f9a2db8551a3ca9e03d5e91b6ed35a3da43..28cd1daa7815d79d21876fb9202810324be7788f 100644

--- a/LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

+++ b/LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

@@ -14,7 +14,8 @@ function setText() {

finishJSTest();

}

gc(); // Because we are recursively entering into setText, can't gc() after this command.

- document.getElementById("object").textContent = "A";

+ // textContent will ignore setting identical text, so use count.

+ document.getElementById("object").textContent = count;

}

document.execCommand("SelectAll");

document.getElementById("object").textContent = "A";

« no previous file with comments | « no previous file | LayoutTests/fast/repaint/set-text-content-same.html » ('j') | no next file with comments »