Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2007623002: Remove unused class CXFA_FFDocWidgetIterator (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused class CXFA_FFDocWidgetIterator This class is not used anywhere. Also there are no implementation of its member functions except MoveToNext() function which was implemented wrong -- direct return in a while loop? BUG=pdfium:29 Committed: https://pdfium.googlesource.com/pdfium/+/09e139e231d1a94bd99ac295f3d66cb26c54ea16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -71 lines) Patch
M xfa/fxfa/app/xfa_ffdocview.cpp View 2 chunks +1 line, -50 lines 0 comments Download
M xfa/fxfa/include/xfa_ffdocview.h View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Wei Li
for review, thanks
4 years, 7 months ago (2016-05-23 17:57:58 UTC) #2
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-23 18:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007623002/1
4 years, 7 months ago (2016-05-23 18:23:43 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 18:51:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/09e139e231d1a94bd99ac295f3d66cb26c54...

Powered by Google App Engine
This is Rietveld 408576698