Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2007593004: Motown: Factor FactoryServiceBase out of MediaFactoryService (Closed)

Created:
4 years, 7 months ago by dalesat
Modified:
4 years, 7 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Factor FactoryServiceBase out of MediaFactoryService Extracts FactoryServiceBase from MediaFactoryService so it can be used for other services (the new logging service will use it). FactoryServiceBase defines the relationship between a factory service and its 'products' and provides a means for controlling the lifetime of products. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eab7f10dbdefd8edbb8bfe06978ba7fb100a452c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -136 lines) Patch
M services/media/factory_service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/media/factory_service/factory_service.h View 2 chunks +2 lines, -69 lines 0 comments Download
M services/media/factory_service/factory_service.cc View 2 chunks +9 lines, -24 lines 0 comments Download
A + services/util/cpp/BUILD.gn View 1 chunk +8 lines, -5 lines 0 comments Download
A + services/util/cpp/factory_service_base.h View 6 chunks +18 lines, -38 lines 0 comments Download
A services/util/cpp/factory_service_base.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 7 months ago (2016-05-23 16:39:50 UTC) #3
kulakowski
lgtm
4 years, 7 months ago (2016-05-24 13:58:44 UTC) #4
dalesat
4 years, 7 months ago (2016-05-24 17:22:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eab7f10dbdefd8edbb8bfe06978ba7fb100a452c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698