Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007573002: Support multiple serialization sources in DeserializerSystemImpl. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support multiple serialization sources in DeserializerSystemImpl. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/552dc14877cf505faba4e8f3792f2ad7018b09ee

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -44 lines) Patch
M pkg/compiler/lib/src/serialization/serialization.dart View 1 4 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 1 chunk +11 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 1 chunk +8 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/library_test.dart View 1 2 5 chunks +36 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-23 14:00:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2007573002/diff/1/pkg/compiler/lib/src/serialization/serialization.dart File pkg/compiler/lib/src/serialization/serialization.dart (right): https://codereview.chromium.org/2007573002/diff/1/pkg/compiler/lib/src/serialization/serialization.dart#newcode914 pkg/compiler/lib/src/serialization/serialization.dart:914: context.deserializers.add(this); It took me some time to figure ...
4 years, 7 months ago (2016-05-23 16:53:06 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 552dc14877cf505faba4e8f3792f2ad7018b09ee (presubmit successful).
4 years, 7 months ago (2016-05-24 08:23:18 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-05-24 09:37:13 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2007573002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/serialization.dart (right):

https://codereview.chromium.org/2007573002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:914:
context.deserializers.add(this);
On 2016/05/23 16:53:06, Siggi Cherem (dart-lang) wrote:
> It took me some time to figure out how `context` gets its list of
deserializers.
> May I suggest that we move this line to the call-site where this constructor
is
> called? I think it helps with readability to have constructors be side-effect
> free.

Agree. Done.

Powered by Google App Engine
This is Rietveld 408576698