Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2007563005: New Tab Page: Work around potentially long delays if model is not loaded. (Closed)

Created:
4 years, 7 months ago by dewittj
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

New Tab Page: Work around potentially long delays if model is not loaded. This avoids querying for offline pages if the model is not loaded, so that the maximum possible delay is minimal (once the model is loaded, all pages are stored in memory). Additionally checks for null when obtaining the offline page model. BUG=607573, 613359 Review-Url: https://codereview.chromium.org/1982483002 Cr-Commit-Position: refs/heads/master@{#395096} (cherry picked from commit 9a12ce07eb8c36407ae27beba7b2082229cf5678) Committed: https://chromium.googlesource.com/chromium/src/+/fac0bea283906de6dffd7e9fe7af6ba5872949fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
4 years, 7 months ago (2016-05-24 17:59:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fac0bea283906de6dffd7e9fe7af6ba5872949fe.

Powered by Google App Engine
This is Rietveld 408576698