Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 2007563004: Revert of [heap] Pass a force_promotion flag to the evacuation routine in the scavenger. (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan, ahaas
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Pass a force_promotion flag to the evacuation routine in the scavenger. (patchset #3 id:40001 of https://codereview.chromium.org/2002013002/ ) Reason for revert: Need to revert JSArrayBuffer change. Please rebase and reland. Original issue's description: > [heap] Pass a force_promotion flag to the evacuation routine in the scavenger. > > The {force_promotion} flag causes the scavenger to move an object to the > old generation instead of to the other semi-space. We use the flag to force > the promotion of objects which are referenced by code objects. > > R=ulan@chromium.org > > Committed: https://crrev.com/f2a7ba6449406d0b11a245aa1f5b4981265b6f20 > Cr-Commit-Position: refs/heads/master@{#36443} TBR=ulan@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b01b9f4b49757a1cfc7138b743139ff9a31ff36a Cr-Commit-Position: refs/heads/master@{#36460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -98 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/heap/scavenger.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/heap/scavenger.cc View 6 chunks +56 lines, -69 lines 0 comments Download
M src/heap/scavenger-inl.h View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Lippautz
Created Revert of [heap] Pass a force_promotion flag to the evacuation routine in the scavenger.
4 years, 7 months ago (2016-05-24 07:17:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007563004/1
4 years, 7 months ago (2016-05-24 07:17:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 07:17:56 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 07:19:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b01b9f4b49757a1cfc7138b743139ff9a31ff36a
Cr-Commit-Position: refs/heads/master@{#36460}

Powered by Google App Engine
This is Rietveld 408576698