Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2007563003: Access-time threshold unit failure in CookieMonster. (Closed)

Created:
4 years, 7 months ago by Scott Hess - ex-Googler
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Access-time threshold unit failure in CookieMonster. kDefaultAccessUpdateThresholdSeconds was being passed to last_access_threshold_milliseconds. As a result, instead of updating the last-access time only once a minute, it was being updated every few seconds. BUG=612989 Review-Url: https://codereview.chromium.org/1988343003 Cr-Commit-Position: refs/heads/master@{#394673} (cherry picked from commit f0bc1185fa559962b4f891c325f0507f847c358f)

Patch Set 1 #

Patch Set 2 : back to scoped_ptr #

Patch Set 3 : empty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M net/cookies/cookie_monster.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Scott Hess - ex-Googler
back to scoped_ptr
4 years, 7 months ago (2016-05-23 21:10:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007563003/20001
4 years, 7 months ago (2016-05-23 21:11:45 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-23 21:11:48 UTC) #5
Scott Hess - ex-Googler
Committed patchset #3 (id:40001) to pending queue manually as 1b96ce859544fd255ff8c2cb7312617d1c12218d.
4 years, 7 months ago (2016-05-23 21:17:11 UTC) #6
Scott Hess - ex-Googler
4 years, 7 months ago (2016-05-23 21:18:15 UTC) #7
Message was sent while issue was closed.
On 2016/05/23 21:17:11, Scott Hess wrote:
> Committed patchset #3 (id:40001) to pending queue manually as
> 1b96ce859544fd255ff8c2cb7312617d1c12218d.

Used "git drover --continue ..."

Powered by Google App Engine
This is Rietveld 408576698