Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
Committed: https://crrev.com/498ec85734442ebbefca2874a934a5700e53e0aa
Cr-Commit-Position: refs/heads/master@{#395988}

[pkotwicz, 2016-05-24 15:32:53]

Description was changed from

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read. This checks
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
==========

to

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
==========

[pkotwicz, 2016-05-24 15:32:53]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-05-24 15:33:06]

Yaron can you please take a look?

[Yaron, 2016-05-24 17:11:29]

On 2016/05/24 15:33:06, pkotwicz wrote:
> Yaron can you please take a look?

I don't think flaky tests are run anywhere upstream. Please also remove the
annotatoin

[pkotwicz, 2016-05-24 17:34:49]

Removed the annotation

[Yaron, 2016-05-24 18:41:46]

lgtm with requested change

https://codereview.chromium.org/2007553005/diff/20001/chrome/android/webapk/s...
File
chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java
(right):

https://codereview.chromium.org/2007553005/diff/20001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java:179:
* @MediumTest
and move this out of the comment :)

[pkotwicz, 2016-05-25 17:18:54]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-25 17:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2007553005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-25 17:19:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007553005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007553005/40001

[commit-bot: I haz the power, 2016-05-25 17:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 17:28:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2016-05-25 19:44:16]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-25 19:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2007553005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-25 19:44:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007553005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007553005/60001

[commit-bot: I haz the power, 2016-05-25 21:28:07]

Description was changed from

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
==========

to

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
==========

[commit-bot: I haz the power, 2016-05-25 21:28:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 21:29:53]

Description was changed from

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116
==========

to

==========
Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG=613116

Committed: https://crrev.com/498ec85734442ebbefca2874a934a5700e53e0aa
Cr-Commit-Position: refs/heads/master@{#395988}
==========

[commit-bot: I haz the power, 2016-05-25 21:29:54]

Patchset 4 (id:??) landed as
https://crrev.com/498ec85734442ebbefca2874a934a5700e53e0aa
Cr-Commit-Position: refs/heads/master@{#395988}