Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp

Issue 2007553002: Retire setGradientSpaceTransform, setPatternSpaceTransform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fmalita discovers SkMatrix::I() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp b/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp
index ad589a5ae9691cce390ed83ec5e9286cd32ea032..7e243fa90dec71c649b193df9ee7d7515fba1256 100644
--- a/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp
@@ -42,7 +42,8 @@ void GradientGeneratedImage::draw(SkCanvas* canvas, const SkPaint& paint, const
canvas->concat(transform);
SkPaint gradientPaint(paint);
- m_gradient->applyToPaint(gradientPaint);
+ // TODO(fmalita): use the shader matrix instead of changing global canvas state.
+ m_gradient->applyToPaint(gradientPaint, SkMatrix::I());
canvas->drawRect(visibleRect, gradientPaint);
}
@@ -50,28 +51,16 @@ void GradientGeneratedImage::draw(SkCanvas* canvas, const SkPaint& paint, const
void GradientGeneratedImage::drawTile(GraphicsContext& context, const FloatRect& srcRect)
{
SkPaint gradientPaint(context.fillPaint());
- m_gradient->applyToPaint(gradientPaint);
+ m_gradient->applyToPaint(gradientPaint, SkMatrix::I());
context.drawRect(srcRect, gradientPaint);
}
bool GradientGeneratedImage::applyShader(SkPaint& paint, const SkMatrix* localMatrix)
{
- AffineTransform transform;
- if (localMatrix) {
- transform.setMatrix(
- localMatrix->getScaleX(), localMatrix->getSkewY(),
- localMatrix->getSkewX(), localMatrix->getScaleY(),
- localMatrix->getTranslateX(), localMatrix->getTranslateY());
- }
-
DCHECK(m_gradient);
- // TODO(fmalita): remove the transform from gradient/pattern state, and pass the matrix to
- // applyToPaint if needed.
- const AffineTransform previousTransform = m_gradient->gradientSpaceTransform();
- m_gradient->setGradientSpaceTransform(transform);
- m_gradient->applyToPaint(paint);
- m_gradient->setGradientSpaceTransform(previousTransform);
+ // TODO(fmalita): pass a const SkMatrix& to applyShader.
+ m_gradient->applyToPaint(paint, localMatrix ? *localMatrix : SkMatrix::I());
return true;
}
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Gradient.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImagePattern.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698