third_party/WebKit/Source/core/paint/ThemePainterMac.mm - Issue 2007553002: Retire setGradientSpaceTransform, setPatternSpaceTransform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

Issue 2007553002: Retire setGradientSpaceTransform, setPatternSpaceTransform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fmalita discovers SkMatrix::I() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasPattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ThemePainterMac.mm

diff --git a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

index 4a33d77df0ae7dc79a8eea1b8975b84c2ba009bf..2e48368b69a38f573730ddc0cc63f51eff313855 100644

--- a/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

+++ b/third_party/WebKit/Source/core/paint/ThemePainterMac.mm

@@ -359,7 +359,7 @@ bool ThemePainterMac::paintSliderTrack(const LayoutObject& o, const PaintInfo& p

FloatRoundedRect borderRRect(borderRect, borderRadius, borderRadius, borderRadius, borderRadius);

paintInfo.context.setStrokeThickness(LayoutThemeMac::sliderTrackBorderWidth);

SkPaint borderPaint(paintInfo.context.strokePaint());

- borderGradient->applyToPaint(borderPaint);

+ borderGradient->applyToPaint(borderPaint, SkMatrix::I());

paintInfo.context.drawRRect(borderRRect, borderPaint);

return false;

@@ -423,7 +423,7 @@ bool ThemePainterMac::paintSliderThumb(const LayoutObject& o, const PaintInfo& p

fillGradient->addColorStop(0.52, fillGradientLowerMiddleColor);

fillGradient->addColorStop(1.0, fillGradientBottomColor);

SkPaint fillPaint(paintInfo.context.fillPaint());

- fillGradient->applyToPaint(fillPaint);

+ fillGradient->applyToPaint(fillPaint, SkMatrix::I());

paintInfo.context.drawOval(borderBounds, fillPaint);

RefPtr<Gradient> borderGradient = Gradient::create(fillBounds.minXMinYCorner(), fillBounds.minXMaxYCorner());

@@ -431,7 +431,7 @@ bool ThemePainterMac::paintSliderThumb(const LayoutObject& o, const PaintInfo& p

borderGradient->addColorStop(1.0, borderGradientBottomColor);

paintInfo.context.setStrokeThickness(LayoutThemeMac::sliderThumbBorderWidth);

SkPaint borderPaint(paintInfo.context.strokePaint());

- borderGradient->applyToPaint(borderPaint);

+ borderGradient->applyToPaint(borderPaint, SkMatrix::I());

paintInfo.context.drawOval(borderBounds, borderPaint);

if (LayoutTheme::isFocused(o)) {