Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2007533002: [telemetry] Add ability to add metadata to the trace data (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, rnephew (Reviews Here), perezju
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Add ability to add metadata to the trace data After this is in, we can add the Telemetry clock domain as trace metadata, which will allow us to 1) Sync clocks between Chrome and Telemetry 2) Stop getting the error about 'a clock domain cannot sync with itself' that forced a revert of https://crrev.com/1980773002/ BUG=catapult:#2341 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f29f40079136c1a5f3a112b03367cb5ead1f18be

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M telemetry/telemetry/timeline/trace_data.py View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data_unittest.py View 1 2 3 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-23 13:13:47 UTC) #2
nednguyen
On 2016/05/23 13:13:47, charliea wrote: Why is this metadata at the container level? According to ...
4 years, 7 months ago (2016-05-23 15:22:07 UTC) #3
charliea (OOO until 10-5)
Rewrote this CL to match what we discussed offline. PTAL
4 years, 7 months ago (2016-05-23 19:36:41 UTC) #6
nednguyen
https://codereview.chromium.org/2007533002/diff/60001/telemetry/telemetry/timeline/trace_data.py File telemetry/telemetry/timeline/trace_data.py (right): https://codereview.chromium.org/2007533002/diff/60001/telemetry/telemetry/timeline/trace_data.py#newcode212 telemetry/telemetry/timeline/trace_data.py:212: This should also assert that self._raw_data[part.raw_field_name] is None/empty to ...
4 years, 7 months ago (2016-05-23 19:42:00 UTC) #7
charliea (OOO until 10-5)
PTAL https://codereview.chromium.org/2007533002/diff/60001/telemetry/telemetry/timeline/trace_data.py File telemetry/telemetry/timeline/trace_data.py (right): https://codereview.chromium.org/2007533002/diff/60001/telemetry/telemetry/timeline/trace_data.py#newcode212 telemetry/telemetry/timeline/trace_data.py:212: On 2016/05/23 19:42:00, nednguyen wrote: > This should ...
4 years, 7 months ago (2016-05-23 19:47:33 UTC) #8
nednguyen
lgtm
4 years, 7 months ago (2016-05-23 19:48:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007533002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007533002/80001
4 years, 7 months ago (2016-05-23 19:49:12 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 20:10:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698