Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2007513002: GYP: In kasko target, export dependent settings of kasko_features (Closed)

Created:
4 years, 7 months ago by blundell
Modified:
4 years, 7 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GYP: In kasko target, export dependent settings of kasko_features Many targets depend on the kasko target for a dependency on the generated header kasko_features.h. However, when kasko is not enabled, the kasko target was not exporting the fact that kasko_features is a hard dependency, causing flaky build failures. This CL fixes the bug. BUG=611319 TBR=pmonette Committed: https://crrev.com/af480cf00ad993ac39e9e3253701879b17d2140b Cr-Commit-Position: refs/heads/master@{#395314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/kasko/kasko.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
blundell
4 years, 7 months ago (2016-05-23 12:14:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007513002/1
4 years, 7 months ago (2016-05-23 12:14:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 14:07:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:09:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af480cf00ad993ac39e9e3253701879b17d2140b
Cr-Commit-Position: refs/heads/master@{#395314}

Powered by Google App Engine
This is Rietveld 408576698