Issue 20075: Fix compiler warning that breaks build since warnings are errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20075: Fix compiler warning that breaks build since warnings are errors. (Closed)

Created:
11 years, 10 months ago by Craig Schlenter

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix compile on GCC 4.3 by adding disambiguating parentheses

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Craig Schlenter

gcc 4.3.x complains if the extra brackets aren't present. Peter: hbono and _ph suggested you ...

11 years, 10 months ago (2009-02-05 12:20:41 UTC) #1

Peter Kasting

LGTM. Avi would also have been a fine reviewer since he wrote that code yesterday.

11 years, 10 months ago (2009-02-05 15:18:27 UTC) #2

Craig Schlenter

On 2009/02/05 15:18:27, pkasting wrote: > LGTM. Avi would also have been a fine reviewer ...

11 years, 10 months ago (2009-02-05 15:55:30 UTC) #3

Committed in r9232.