Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2007453002: [Interpreter] Make lazy compilation the default. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Make lazy compilation the default. BUG=v8:4280, v8:5038 LOG=N Committed: https://crrev.com/5c602c6fcc70154ff97322996861d72a3e62f34a Cr-Commit-Position: refs/heads/master@{#36476}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Disable tests failing with --turbo-from-bytecode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -46 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 2 chunks +0 lines, -30 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 3 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 chunks +10 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (12 generated)
rmcilroy
PTAL, thanks.
4 years, 7 months ago (2016-05-23 09:17:59 UTC) #2
oth
lgtm
4 years, 7 months ago (2016-05-23 10:12:52 UTC) #3
oth
lgtm
4 years, 7 months ago (2016-05-23 10:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007453002/1
4 years, 7 months ago (2016-05-23 11:00:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2030) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-23 11:18:48 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007453002/20001
4 years, 7 months ago (2016-05-23 16:18:10 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2137) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-23 16:51:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007453002/40001
4 years, 7 months ago (2016-05-24 12:04:46 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 12:35:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007453002/40001
4 years, 7 months ago (2016-05-24 12:49:23 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-24 12:51:24 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 12:53:01 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c602c6fcc70154ff97322996861d72a3e62f34a
Cr-Commit-Position: refs/heads/master@{#36476}

Powered by Google App Engine
This is Rietveld 408576698