Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007423003: Short circuit for 'as dynamic' (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 6 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Leaf
4 years, 7 months ago (2016-05-26 04:37:12 UTC) #2
Jacob
lgtm
4 years, 7 months ago (2016-05-26 04:40:52 UTC) #3
Leaf
Committed patchset #1 (id:1) manually as 0885b1510ce41a06e33a6fd80b5a9b94c68da3d3 (presubmit successful).
4 years, 7 months ago (2016-05-26 04:44:39 UTC) #5
Jennifer Messerly
https://codereview.chromium.org/2007423003/diff/1/tool/input_sdk/private/ddc_runtime/operations.dart File tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2007423003/diff/1/tool/input_sdk/private/ddc_runtime/operations.dart#newcode256 tool/input_sdk/private/ddc_runtime/operations.dart:256: if (JS('bool', '# == #', type, dynamic) || obj ...
4 years, 6 months ago (2016-05-26 18:14:51 UTC) #7
Leaf
4 years, 6 months ago (2016-05-26 18:16:38 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2007423003/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/operations.dart (right):

https://codereview.chromium.org/2007423003/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/operations.dart:256: if (JS('bool', '# == #',
type, dynamic) || obj == null) return obj;
On 2016/05/26 18:14:51, John Messerly wrote:
> super trivial but: wouldn't null be more common than casts against `dynamic`?

Maybe, but I doubt it.  By far the majority of the casts that I've measured are
against dynamic, because of our generic argument checks (e.g.
List<dynamic>.add(x) casts x to dynamic).

Powered by Google App Engine
This is Rietveld 408576698