Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2007423002: Enums recently moved to separate files should still be in the blink namespace. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enums recently moved to separate files should still be in the blink namespace. TBR=eae@chromium.org Committed: https://crrev.com/3b315c013fbe97ccfd2525888f0fa2c8a1243fff Cr-Commit-Position: refs/heads/master@{#395978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/BackgroundBleedAvoidance.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ContentChangeType.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollEnums.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mstensho (USE GERRIT)
Forgot to namespace all the things! :-(
4 years, 7 months ago (2016-05-25 19:30:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007423002/1
4 years, 7 months ago (2016-05-25 19:30:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 20:20:43 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b315c013fbe97ccfd2525888f0fa2c8a1243fff Cr-Commit-Position: refs/heads/master@{#395978}
4 years, 7 months ago (2016-05-25 20:23:00 UTC) #9
eae
4 years, 7 months ago (2016-05-25 20:24:20 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698