Fix invalid DCHECK in EmbeddedApplicationRunner

Fix invalid DCHECK in EmbeddedApplicationRunner

ThreadChecker checks that ShellClient messages are dispatched
on the app thread, but we weren't detaching it when spinning up
a new thread for the app.

So start -> shutdown -> start would incorrectly hit a DCHECK.

This fixes that.

BUG=614554
R=xhwang@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26
Cr-Commit-Position: refs/heads/master@{#395974}

[xhwang, 2016-05-25 17:30:27]

The fix lg, but I have a question.

https://codereview.chromium.org/2007383002/diff/1/content/common/mojo/embedde...
File content/common/mojo/embedded_application_runner.cc (right):

https://codereview.chromium.org/2007383002/diff/1/content/common/mojo/embedde...
content/common/mojo/embedded_application_runner.cc:129: base::ThreadChecker
application_thread_checker_;
Does it make sense to just use 

application_task_runner_->BelongsToCurrentThread()

to check whether certain operation is run on the application task runner's
thread?

[Ken Rockot(use gerrit already), 2016-05-25 17:47:48]

On 2016/05/25 at 17:30:27, xhwang wrote:
> The fix lg, but I have a question.
> 
>
https://codereview.chromium.org/2007383002/diff/1/content/common/mojo/embedde...
> File content/common/mojo/embedded_application_runner.cc (right):
> 
>
https://codereview.chromium.org/2007383002/diff/1/content/common/mojo/embedde...
> content/common/mojo/embedded_application_runner.cc:129: base::ThreadChecker
application_thread_checker_;
> Does it make sense to just use 
> 
> application_task_runner_->BelongsToCurrentThread()
> 
> to check whether certain operation is run on the application task runner's
thread?

Even better. Done

[xhwang, 2016-05-25 17:51:55]

lgtm

[Ken Rockot(use gerrit already), 2016-05-25 19:39:53]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-05-25 19:40:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007383002/20001

[commit-bot: I haz the power, 2016-05-25 19:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 19:49:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-05-25 19:50:00]

Description was changed from

==========
Fix invalid DCHECK in EmbeddedApplicationRunner

ThreadChecker checks that ShellClient messages are dispatched
on the app thread, but we weren't detaching it when spinning up
a new thread for the app.

So start -> shutdown -> start would incorrectly hit a DCHECK.

This fixes that.

BUG=614554
R=xhwang@chromium.org
==========

to

==========
Fix invalid DCHECK in EmbeddedApplicationRunner

ThreadChecker checks that ShellClient messages are dispatched
on the app thread, but we weren't detaching it when spinning up
a new thread for the app.

So start -> shutdown -> start would incorrectly hit a DCHECK.

This fixes that.

BUG=614554
R=xhwang@chromium.org
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-05-25 19:50:03]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-05-25 19:50:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007383002/20001

[commit-bot: I haz the power, 2016-05-25 20:15:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 20:17:12]

Description was changed from

==========
Fix invalid DCHECK in EmbeddedApplicationRunner

ThreadChecker checks that ShellClient messages are dispatched
on the app thread, but we weren't detaching it when spinning up
a new thread for the app.

So start -> shutdown -> start would incorrectly hit a DCHECK.

This fixes that.

BUG=614554
R=xhwang@chromium.org
TBR=ben@chromium.org
==========

to

==========
Fix invalid DCHECK in EmbeddedApplicationRunner

ThreadChecker checks that ShellClient messages are dispatched
on the app thread, but we weren't detaching it when spinning up
a new thread for the app.

So start -> shutdown -> start would incorrectly hit a DCHECK.

This fixes that.

BUG=614554
R=xhwang@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26
Cr-Commit-Position: refs/heads/master@{#395974}
==========

[commit-bot: I haz the power, 2016-05-25 20:17:14]

Patchset 2 (id:??) landed as
https://crrev.com/ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26
Cr-Commit-Position: refs/heads/master@{#395974}