Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007353002: run dartfmt on dart2js (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -97 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 4 chunks +11 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 1 chunk +87 lines, -78 lines 1 comment Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 7 months ago (2016-05-25 16:39:43 UTC) #2
Harry Terkelsen
https://codereview.chromium.org/2007353002/diff/1/pkg/compiler/lib/src/dart_types.dart File pkg/compiler/lib/src/dart_types.dart (right): https://codereview.chromium.org/2007353002/diff/1/pkg/compiler/lib/src/dart_types.dart#newcode645 pkg/compiler/lib/src/dart_types.dart:645: this.containsMethodTypeVariableType = returnType it looked better before dartfmt
4 years, 7 months ago (2016-05-25 16:44:17 UTC) #3
Siggi Cherem (dart-lang)
lgtm this reminds me, let's also run it under tests/compiler/dart2js/... https://codereview.chromium.org/2007353002/diff/1/pkg/compiler/lib/src/dart_types.dart File pkg/compiler/lib/src/dart_types.dart (right): https://codereview.chromium.org/2007353002/diff/1/pkg/compiler/lib/src/dart_types.dart#newcode645 ...
4 years, 7 months ago (2016-05-25 17:04:16 UTC) #4
Harry Terkelsen
4 years, 7 months ago (2016-05-25 17:14:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
74765602098949d2a2d3df703c2d56022109f8d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698