Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2007313002: [Android] Fix regex in AcceptLanguageTest. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix regex in AcceptLanguageTest. It had not been properly splitting on terminal quality factors, e.g. "en-US;q=0.8" would get split into exactly that rather than into "en-US" as intended. BUG=614715 Committed: https://crrev.com/be9b84822febd4cf965f88f426661eab3ba589f9 Cr-Commit-Position: refs/heads/master@{#395933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AcceptLanguageTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 7 months ago (2016-05-25 14:31:44 UTC) #2
sgurun-gerrit only
lgtm
4 years, 6 months ago (2016-05-25 17:54:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007313002/1
4 years, 6 months ago (2016-05-25 18:07:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 18:13:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 18:15:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be9b84822febd4cf965f88f426661eab3ba589f9
Cr-Commit-Position: refs/heads/master@{#395933}

Powered by Google App Engine
This is Rietveld 408576698