third_party/WebKit/Source/platform/heap/PersistentNode.cpp - Issue 2007283002: Allow CrossThreadPersistent in collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

Issue 2007283002: Allow CrossThreadPersistent in collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

index 2c512958fed0f56d3fa88e42fe2b6710c21e5b8d..615b6cb76a356fdcadac8dc0dd2a834005e16ddc 100644

--- a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp

@@ -124,7 +124,8 @@ void PersistentRegion::tracePersistentNodes(Visitor* visitor, ShouldTraceCallbac

bool CrossThreadPersistentRegion::shouldTracePersistentNode(Visitor* visitor, PersistentNode* node)

{

CrossThreadPersistent<DummyGCBase>* persistent = reinterpret_cast<CrossThreadPersistent<DummyGCBase>*>(node->self());

- ASSERT(persistent);

+ DCHECK(persistent);

+ DCHECK(!persistent->isHashTableDeletedValue());

Address rawObject = reinterpret_cast<Address>(persistent->get());

if (!rawObject)

return false;