third_party/WebKit/Source/platform/heap/Heap.h - Issue 2007283002: Allow CrossThreadPersistent in collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.h

Issue 2007283002: Allow CrossThreadPersistent in collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Heap.h

diff --git a/third_party/WebKit/Source/platform/heap/Heap.h b/third_party/WebKit/Source/platform/heap/Heap.h

index 40482db58d209521ff8e441509afa93a356ac2cb..2b51421d4f51f8eb99f1aef788946c8cbed91364 100644

--- a/third_party/WebKit/Source/platform/heap/Heap.h

+++ b/third_party/WebKit/Source/platform/heap/Heap.h

@@ -202,6 +202,9 @@ public:

// always 'alive'.

if (!object)

return true;

+ // TODO(keishi): some tests create CrossThreadPersistent on non attached threads.

+ if (!ThreadState::current())

sof 2016/05/26 12:09:41 What's going wrong without this bail out? I though

keishi 2016/05/26 12:32:04 Sorry this is part of https://codereview.chromium.

+ return true;

return ObjectAliveTrait<T>::isHeapObjectAlive(object);

}

template<typename T>