Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2007273003:
Remove unused method setup_destination_directory in test_importer.py. (Closed)
|
Created:
4 years, 7 months ago by qyearsley Modified:
4 years, 6 months ago CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused method setup_destination_directory in test_importer.py.
Committed: https://crrev.com/f83da9eae8ecbbd8541fae566d35ce33a191733a
Cr-Commit-Position: refs/heads/master@{#397181}
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 18 (8 generated)
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org, jsbell@chromium.org
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007273003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Dry run: None
lgtm
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007273003/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:
While running git apply --index -3 -p1;
error: patch failed:
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:413
Falling back to three-way merge...
Applied patch to
'third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py' with conflicts.
U third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
Patch: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
index
0f31e097b0cc9b91cd1f27350462ac8c2bc60362..19b7dc3efe273f3e6d79ed5febdea7939bbd2573
100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
@@ -413,15 +413,3 @@ class TestImporter(object):
"""
path_from_repo_base = os.path.relpath(source_path, self.top_of_repo)
return len(path_from_repo_base) > MAX_PATH_LENGTH
-
- def setup_destination_directory(self):
- """ Creates a destination directory that mirrors that of the source
directory """
-
- new_subpath = self.dir_to_import[len(self.top_of_repo):]
-
- destination_directory =
self.filesystem.join(self.destination_directory, new_subpath)
-
- if not self.filesystem.exists(destination_directory):
- self.filesystem.maybe_make_directory(destination_directory)
-
- _log.info('Tests will be imported into: %s', destination_directory)
The CQ bit was checked by qyearsley@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2007273003/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007273003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove unused method setup_destination_directory in test_importer.py. ========== to ========== Remove unused method setup_destination_directory in test_importer.py. Committed: https://crrev.com/f83da9eae8ecbbd8541fae566d35ce33a191733a Cr-Commit-Position: refs/heads/master@{#397181} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f83da9eae8ecbbd8541fae566d35ce33a191733a Cr-Commit-Position: refs/heads/master@{#397181} |
