Issue 2007233002: Add --dump-megamorphic-stats. Lower megamorphic cache load factor to 50%. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(32)

My Issues | Starred Open | Closed | All

Issue 2007233002: Add --dump-megamorphic-stats. Lower megamorphic cache load factor to 50%. (Closed)

Created:
4 years, 7 months ago by rmacnak

Modified:
4 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add --dump-megamorphic-stats. Lower megamorphic cache load factor to 50%. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/4aaf810d25a337edc90352686f2b453fdc51860d

Patch Set 1 #

Total comments: 1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -2 lines)			Patch
	M	runtime/vm/flag_list.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	runtime/vm/isolate.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	runtime/vm/megamorphic_cache_table.cc	View		1 chunk	+50 lines, -0 lines	1 comment	Download
	M	runtime/vm/object.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

CompileOnceHelloHtml spread 1, load 75% (old behavior) 96 megamorphic caches using 60KB. Megamorphic probe 0: ...

4 years, 7 months ago (2016-05-25 02:52:09 UTC) #2

CompileOnceHelloHtml

spread 1, load 75%  (old behavior)
96 megamorphic caches using 60KB.
Megamorphic probe 0: 0 (0.000000)
Megamorphic probe 1: 1312 (0.846998)
Megamorphic probe 2: 108 (0.916720)
Megamorphic probe 3: 56 (0.952873)
Megamorphic probe 4: 27 (0.970303)
Megamorphic probe 5: 7 (0.974822)
Megamorphic probe 6: 7 (0.979342)
Megamorphic probe 7: 5 (0.982569)
Megamorphic probe 8: 0 (0.982569)
Megamorphic probe 9: 3 (0.984506)
Megamorphic probe 10: 5 (0.987734)
Megamorphic probe 11: 5 (0.990962)
Megamorphic probe 12: 4 (0.993544)
Megamorphic probe 13: 0 (0.993544)
Megamorphic probe 14: 3 (0.995481)
Megamorphic probe 15: 0 (0.995481)
Megamorphic probe 16: 0 (0.995481)
Megamorphic probe 17: 0 (0.995481)
Megamorphic probe 18: 2 (0.996772)
Megamorphic probe 19: 2 (0.998063)
Megamorphic probe 20: 0 (0.998063)
Megamorphic probe 21: 1 (0.998709)
Megamorphic probe 22: 0 (0.998709)
Megamorphic probe 23: 1 (0.999354)
Megamorphic probe 24: 0 (0.999354)
Megamorphic probe 25: 0 (0.999354)
Megamorphic probe 26: 0 (0.999354)
Megamorphic probe 27: 0 (0.999354)
Megamorphic probe 28: 1 (1.000000)


spread 7, load 75% (top of tree)
96 megamorphic caches using 59KB.
Megamorphic probe 0: 0 (0.000000)
Megamorphic probe 1: 1310 (0.863546)
Megamorphic probe 2: 119 (0.941991)
Megamorphic probe 3: 42 (0.969677)
Megamorphic probe 4: 34 (0.992090)
Megamorphic probe 5: 6 (0.996045)
Megamorphic probe 6: 4 (0.998682)
Megamorphic probe 7: 1 (0.999341)
Megamorphic probe 8: 1 (1.000000)


spead 7, load 65%
96 megamorphic caches using 62KB.
Megamorphic probe 0: 0 (0.000000)
Megamorphic probe 1: 1340 (0.880420)
Megamorphic probe 2: 109 (0.952037)
Megamorphic probe 3: 41 (0.978975)
Megamorphic probe 4: 27 (0.996715)
Megamorphic probe 5: 3 (0.998686)
Megamorphic probe 6: 2 (1.000000)

spread 7, load 50%
96 megamorphic caches using 77KB.
Megamorphic probe 0: 0 (0.000000)
Megamorphic probe 1: 1404 (0.926121)
Megamorphic probe 2: 87 (0.983509)
Megamorphic probe 3: 19 (0.996042)
Megamorphic probe 4: 5 (0.999340)
Megamorphic probe 5: 1 (1.000000)


spread 1, load 50%
96 megamorphic caches using 79KB.
Megamorphic probe 0: 0 (0.000000)
Megamorphic probe 1: 1396 (0.914810)
Megamorphic probe 2: 62 (0.955439)
Megamorphic probe 3: 33 (0.977064)
Megamorphic probe 4: 12 (0.984928)
Megamorphic probe 5: 4 (0.987549)
Megamorphic probe 6: 2 (0.988860)
Megamorphic probe 7: 2 (0.990170)
Megamorphic probe 8: 0 (0.990170)
Megamorphic probe 9: 3 (0.992136)
Megamorphic probe 10: 4 (0.994758)
Megamorphic probe 11: 3 (0.996723)
Megamorphic probe 12: 1 (0.997379)
Megamorphic probe 13: 1 (0.998034)
Megamorphic probe 14: 0 (0.998034)
Megamorphic probe 15: 0 (0.998034)
Megamorphic probe 16: 0 (0.998034)
Megamorphic probe 17: 0 (0.998034)
Megamorphic probe 18: 0 (0.998034)
Megamorphic probe 19: 2 (0.999345)
Megamorphic probe 20: 1 (1.000000)

Ivan Posva

LGTM -ip https://codereview.chromium.org/2007233002/diff/1/runtime/vm/megamorphic_cache_table.cc File runtime/vm/megamorphic_cache_table.cc (right): https://codereview.chromium.org/2007233002/diff/1/runtime/vm/megamorphic_cache_table.cc#newcode144 runtime/vm/megamorphic_cache_table.cc:144: for (intptr_t i = 0; i <= ...

4 years, 7 months ago (2016-05-25 17:27:53 UTC) #3

rmacnak

4 years, 7 months ago (2016-05-25 21:03:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4aaf810d25a337edc90352686f2b453fdc51860d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698