samples/pop-pop-win/test/browser_test_harness.dart - Issue 200723008: samples/poppopwin: upgrade to first-class sample

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: samples/pop-pop-win/test/browser_test_harness.dart

Issue 200723008: samples/poppopwin: upgrade to first-class sample (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: cl comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 import 'package:unittest/html_enhanced_config.dart';	1 import 'package:unittest/html_enhanced_config.dart';

2 import 'ppw/_ppw_runner.dart';	2 import 'ppw/_ppw_runner.dart';
	Jennifer Messerly 2014/03/19 14:26:43 style nit: we usually don't name files starting wi style nit: we usually don't name files starting with underscore. kevmoo 2014/03/19 21:17:01 I'll do another run-through for these later. Just Show quoted text On 2014/03/19 14:26:43, John Messerly wrote: > style nit: we usually don't name files starting with underscore. I'll do another run-through for these later. Just trying to hit the basics now.
3	3

4 main() {	4 main() {
	Jennifer Messerly 2014/03/19 14:26:43 If you name this file _test.dart, it should get p If you name this file _test.dart, it should get picked up automatically by buildbots. Basically anything ending in _test.dart is automatically picked up. You won't need the two harnesses. then you can run it with: # console vm ./tools/test.py -m release samples/pop-pop-win # content_shell dart vm ./tools/test.py -m release -r drt samples/pop-pop-win # dart2js various browsers ./tools/test.py -m release -r drt,ff,chrome -c dart2js samples/pop-pop-win # analyzer ./tools/test.py -m release -r none -c dartanalyzer samples/pop-pop-win kevmoo* 2014/03/19 21:17:01 Again, a good follow-up for the next CL. I don't w Show quoted text On 2014/03/19 14:26:43, John Messerly wrote: > If you name this file _test.dart, it should get picked up automatically by > buildbots. > > Basically anything ending in _test.dart is automatically picked up. You won't > need the two harnesses. > > then you can run it with: > > > # console vm > ./tools/test.py -m release samples/pop-pop-win > > # content_shell dart vm > ./tools/test.py -m release -r drt samples/pop-pop-win > > # dart2js various browsers > ./tools/test.py -m release -r drt,ff,chrome -c dart2js samples/pop-pop-win > > # analyzer > ./tools/test.py -m release -r none -c dartanalyzer samples/pop-pop-win Again, a good follow-up for the next CL. I don't want to churn more here.
5 useHtmlEnhancedConfiguration();	5 useHtmlEnhancedConfiguration();

6	6

7 runppwTests();	7 runppwTests();
	Jennifer Messerly 2014/03/19 14:26:43 should this be "runPpwTests()" ? should this be "runPpwTests()" ? kevmoo 2014/03/19 21:17:01 Yup. Again, let me get this set of changes through Show quoted text On 2014/03/19 14:26:43, John Messerly wrote: > should this be "runPpwTests()" ? Yup. Again, let me get this set of changes through.
8 }	8 }

OLD	NEW

« no previous file with comments | « samples/pop-pop-win/readme.md ('k') | samples/pop-pop-win/test/browser_test_harness.html » ('j') | samples/pop-pop-win/test/ppw/_ppw_runner.dart » ('J')