Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2558)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 200723002: Use new is*Element() helper functions more in web/ code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/ContextMenuClientImpl.cpp » ('j') | Source/web/WebFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 89c16b709325a15d0161415fa32fbe17fbb7a2f2..0d93d8c5a15ac83732716ca738ae6bd33439d635 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -543,11 +543,11 @@ void ChromeClientImpl::mouseDidMoveOverElement(
WebURL url;
// Find out if the mouse is over a link, and if so, let our UI know...
- if (result.isLiveLink() && !result.absoluteLinkURL().string().isEmpty())
+ if (result.isLiveLink() && !result.absoluteLinkURL().string().isEmpty()) {
url = result.absoluteLinkURL();
- else if (result.innerNonSharedNode()
- && (result.innerNonSharedNode()->hasTagName(HTMLNames::objectTag)
- || result.innerNonSharedNode()->hasTagName(HTMLNames::embedTag))) {
+ } else if (result.innerNonSharedNode()
+ && (isHTMLObjectElement(*result.innerNonSharedNode())
adamk 2014/03/14 20:49:12 I liked the original indentation better, but I'm g
Inactive 2014/03/14 21:07:17 Yes, the style script complained about indentation
+ || isHTMLEmbedElement(*result.innerNonSharedNode()))) {
RenderObject* object = result.innerNonSharedNode()->renderer();
if (object && object->isWidget()) {
Widget* widget = toRenderWidget(object)->widget();
« no previous file with comments | « no previous file | Source/web/ContextMenuClientImpl.cpp » ('j') | Source/web/WebFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698