Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2007143003:
[gn] Add cctest (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Add cctest
BUG=chromium:474921
Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c
Cr-Commit-Position: refs/heads/master@{#36517}
Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4
Cr-Commit-Position: refs/heads/master@{#36586}
TBR=jochen@chromium.org
Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21
Cr-Commit-Position: refs/heads/master@{#36607}
Committed: https://crrev.com/9d5b4b6cd9ff3e5bd98659013ea0be7a178956d0
Cr-Commit-Position: refs/heads/master@{#36648}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Rebase #Patch Set 3 : Fix #Patch Set 4 : Fix #Patch Set 5 : Fix, rebase, comment #
Messages
Total messages: 50 (24 generated)
Description was changed from ========== [gn] Add cctest BUG= ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true ==========
machenbach@chromium.org changed reviewers: + vogelheim@chromium.org
PTAL https://codereview.chromium.org/2007143003/diff/1/test/cctest/BUILD.gn File test/cctest/BUILD.gn (right): https://codereview.chromium.org/2007143003/diff/1/test/cctest/BUILD.gn#newcode2 test/cctest/BUILD.gn:2: # Use of this source code is governed by a BSD-style license that can be Ports https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/cctest/cct... https://codereview.chromium.org/2007143003/diff/1/test/cctest/BUILD.gn#newcod... test/cctest/BUILD.gn:171: "test-code-stubs.cc", test-code-stubs.cc appears in all sections. But I postpone refactoring to follow ups. This is gyp-equivalent now. https://codereview.chromium.org/2007143003/diff/1/test/cctest/BUILD.gn#newcod... test/cctest/BUILD.gn:317: action("resources") { The boilerplate is copied from https://code.google.com/p/chromium/codesearch#chromium/src/v8/BUILD.gn&l=333 We could make our own template for this in a follow up.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007143003/1
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2008543007/ by hablich@chromium.org. The reason for reverting is: Reason for revert: Speculative revert because of roll block: https://codereview.chromium.org/2004203004/.
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org
PTAL. Patch 1 shows the failing bots. Patch 3 adds the fix (same as with unittests before).
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007143003/40001
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2021213002/ by hablich@chromium.org. The reason for reverting is: Blocks Roll https://bugs.chromium.org/p/chromium/issues/detail?id=615890.
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ========== to ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ==========
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007143003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007143003/60001
PTAL at fix in patch 4 for http://crbug.com/615890
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
TBR to see results of the non-CQ arm builder on the waterfall...
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org ==========
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/2007143003/#ps60001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007143003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007143003/60001
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2026703002/ by machenbach@chromium.org. The reason for reverting is: Still http://crbug.com/615890.
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ==========
PTAL at patch 5. Same fix, rebase + comment as for unittests.
On 2016/06/01 13:04:32, Michael Achenbach wrote: > PTAL at patch 5. Same fix, rebase + comment as for unittests. Passes now on all relevant bots. Going to reland...
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org, vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/2007143003/#ps80001 (title: "Fix, rebase, comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007143003/80001
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} ========== to ========== [gn] Add cctest BUG=chromium:474921 Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c Cr-Commit-Position: refs/heads/master@{#36517} Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 Cr-Commit-Position: refs/heads/master@{#36586} TBR=jochen@chromium.org Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 Cr-Commit-Position: refs/heads/master@{#36607} Committed: https://crrev.com/9d5b4b6cd9ff3e5bd98659013ea0be7a178956d0 Cr-Commit-Position: refs/heads/master@{#36648} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/9d5b4b6cd9ff3e5bd98659013ea0be7a178956d0 Cr-Commit-Position: refs/heads/master@{#36648} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
