chrome/browser/resources/md_user_manager/user_manager.html - Issue 2007133006: Use svg icon to avoid lazy loading of Polymer elements for user pods

Side by Side Diff: chrome/browser/resources/md_user_manager/user_manager.html

Issue 2007133006: Use svg icon to avoid lazy loading of Polymer elements for user pods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/login_shared.js ('k') | chrome/browser/resources/md_user_manager/user_manager.js » ('j') | ui/login/account_picker/user_pod_row.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html build="$i18n{buildType}"	2 <html build="$i18n{buildType}"

3 dir="$i18n{textdirection}"	3 dir="$i18n{textdirection}"

4 lang="$i18n{language}"	4 lang="$i18n{language}"

5 screen="$i18n{screenType}">	5 screen="$i18n{screenType}">

6 <head>	6 <head>

7 <meta charset="utf-8">	7 <meta charset="utf-8">

8 <meta name="google" value="notranslate">	8 <meta name="google" value="notranslate">

9 <title>$i18n{title}</title>	9 <title>$i18n{title}</title>

10	10

11 <link rel="stylesheet" href="../../../../ui/login/account_picker/screen_accoun t_picker.css">	11 <link rel="stylesheet" href="../../../../ui/login/account_picker/screen_accoun t_picker.css">

12 <link rel="stylesheet" href="../../../../ui/login/account_picker/user_pod_row. css">	12 <link rel="stylesheet" href="../../../../ui/login/account_picker/user_pod_row. css">

13 <link rel="stylesheet" href="../../../../ui/login/bubble.css">	13 <link rel="stylesheet" href="../../../../ui/login/bubble.css">

14 <link rel="stylesheet" href="../../../../ui/login/oobe.css">	14 <link rel="stylesheet" href="../../../../ui/login/oobe.css">

15 <link rel="stylesheet" href="../../../../ui/login/screen_container.css">	15 <link rel="stylesheet" href="../../../../ui/login/screen_container.css">

16 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	16 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

17	17

	18 <link rel="import" href="chrome://resources/html/polymer.html">

	19 <link rel="import" href="chrome://resources/cr_elements/icons.html">

	20 <!-- Make sure iron-icon is imported to use in user_pod_template.html -->

	21 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.h tml">

	22 <!-- Make sure paper-button is imported to use in user_pod_template.html -->
	Dan Beam 2016/05/26 00:35:11 i'm confused, why can't we just import directly fr i'm confused, why can't we just import directly from user_pod_template.html? Moe 2016/05/26 13:36:49 If I understand correctly, that would cause a dela Show quoted text On 2016/05/26 00:35:11, Dan Beam wrote: > i'm confused, why can't we just import directly from user_pod_template.html? If I understand correctly, that would cause a delay in displaying the user pods in cros. jdufault@ originally landed lazy loading of Polymer: https://codereview.chromium.org/1808223003 the iron-icon and paper-button that are left in user_pod_template.html after this CL are used only on desktop. Hence importing the resources explicitly here. jdufault 2016/05/26 17:04:15 Right - loading polymer takes a very long time whe Show quoted text On 2016/05/26 13:36:49, Moe wrote: > On 2016/05/26 00:35:11, Dan Beam wrote: > > i'm confused, why can't we just import directly from user_pod_template.html? > > If I understand correctly, that would cause a delay in displaying the user pods > in cros. jdufault@ originally landed lazy loading of Polymer: > https://codereview.chromium.org/1808223003 Right - loading polymer takes a very long time when displaying the lock screen, especially on slower devices. Moreover, if the lock screen takes too long to load, then we intentionally crash chrome.
	23 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">

18 <link rel="import" href="chrome://md-user-manager/control_bar.html">	24 <link rel="import" href="chrome://md-user-manager/control_bar.html">

19 <link rel="import" href="chrome://md-user-manager/user_manager_pages.html">	25 <link rel="import" href="chrome://md-user-manager/user_manager_pages.html">

20 <link rel="import" href="chrome://md-user-manager/user_manager_styles.html">	26 <link rel="import" href="chrome://md-user-manager/user_manager_styles.html">

21 <link rel="import" href="chrome://md-user-manager/user_manager_tutorial.html">	27 <link rel="import" href="chrome://md-user-manager/user_manager_tutorial.html">

22 <link rel="import" href="chrome://resources/html/cr/ui.html">	28 <link rel="import" href="chrome://resources/html/cr/ui.html">

23 <link rel="import" href="chrome://resources/html/util.html">	29 <link rel="import" href="chrome://resources/html/util.html">

24 <style is="custom-style" include="user-manager-styles"></style>	30 <style is="custom-style" include="user-manager-styles"></style>

25 </head>	31 </head>

26 <body>	32 <body>

27 <user-manager-pages>	33 <user-manager-pages>

(...skipping 10 matching lines...) Expand all Loading...
38 </div>	44 </div>

39 <div id="bubble" class="bubble faded" hidden></div>	45 <div id="bubble" class="bubble faded" hidden></div>

40 <control-bar id="login-header-bar"></control-bar>	46 <control-bar id="login-header-bar"></control-bar>

41 <include src="../../../../ui/login/account_picker/user_pod_template.html">	47 <include src="../../../../ui/login/account_picker/user_pod_template.html">

42 </user-manager-pages>	48 </user-manager-pages>

43 <link rel="import" href="chrome://md-user-manager/strings.html">	49 <link rel="import" href="chrome://md-user-manager/strings.html">

44 <link rel="import" href="chrome://resources/html/i18n_template.html">	50 <link rel="import" href="chrome://resources/html/i18n_template.html">

45 <script src="user_manager.js"></script>	51 <script src="user_manager.js"></script>

46 </body>	52 </body>

47 </html>	53 </html>

OLD	NEW