Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2007133005: Cap the maximum number of flaky tests that we record from a step (Closed)

Created:
4 years, 7 months ago by Sergiy Byelozyorov
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M appengine/chromium_try_flakes/handlers/flake_issues.py View 2 chunks +3 lines, -0 lines 0 comments Download
M appengine/chromium_try_flakes/handlers/test/flake_issues_test.py View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergiy Byelozyorov
4 years, 7 months ago (2016-05-25 17:15:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007133005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007133005/1
4 years, 7 months ago (2016-05-25 17:17:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%2064%20Tester/builds/1906)
4 years, 7 months ago (2016-05-25 17:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007133005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007133005/20001
4 years, 7 months ago (2016-05-25 17:31:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/76806e4d57ac6cebbb0c67900d8ac73870f569e8
4 years, 7 months ago (2016-05-25 17:35:08 UTC) #11
ojan
4 years, 7 months ago (2016-05-25 17:43:29 UTC) #12
Message was sent while issue was closed.
Please do more descriptive change descriptions in the future. This actually
considers the whole step to have failed if too many tests fail. I think that's
the right behavior, it's just not clear from the description that this patch
does that.

Also, in an ideal world, we'd use the same cap as the one used by the recipes in
deciding whether to retry a step without the patch.

Powered by Google App Engine
This is Rietveld 408576698