Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 2007133004: Disallow navigation to documents not explicitly listed as web accessible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix up subframe cases. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_protocols_unittest.cc
diff --git a/chrome/browser/extensions/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc
index 511e8b0138503f4220983ab7f198d487ccdee896..0dbecbda7b3c4f3b74cdf5dbf043a402c6955646 100644
--- a/chrome/browser/extensions/extension_protocols_unittest.cc
+++ b/chrome/browser/extensions/extension_protocols_unittest.cc
@@ -198,8 +198,8 @@ TEST_F(ExtensionProtocolTest, IncognitoRequest) {
} cases[] = {
{"spanning disabled", false, false, false, false},
{"split disabled", true, false, false, false},
- {"spanning enabled", false, true, false, true},
- {"split enabled", true, true, true, true},
+ {"spanning enabled", false, true, false, false},
+ {"split enabled", true, true, true, false},
};
for (size_t i = 0; i < arraysize(cases); ++i) {
@@ -361,7 +361,7 @@ TEST_F(ExtensionProtocolTest, AllowFrameRequests) {
extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
&test_delegate_));
StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
- EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
+ EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
}
// And subresource types, such as media, should fail.

Powered by Google App Engine
This is Rietveld 408576698