Disallow navigation to documents not explicitly listed as web accessible.
The existing check for web accessible resources is inadequate and allows
navigations to non-whitelisted pages to succeed. This patch ensures that
the document is listed explicitly in the manifest when a navigation is
performed to it.
BUG=576867
Committed: https://crrev.com/5cf9d45c437b7b2d899e46f2f324c147a2743eb7
Cr-Commit-Position: refs/heads/master@{#397066}
https://codereview.chromium.org/2007133004/diff/120001/chrome/browser/extensions/extension_protocols_unittest.cc File chrome/browser/extensions/extension_protocols_unittest.cc (right): https://codereview.chromium.org/2007133004/diff/120001/chrome/browser/extensions/extension_protocols_unittest.cc#newcode349 chrome/browser/extensions/extension_protocols_unittest.cc:349: // All MAIN_FRAME and SUB_FRAME requests should succeed. On ...
3 years, 6 months ago
(2016-05-31 23:16:17 UTC)
#4
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007133004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007133004/140001
3 years, 6 months ago
(2016-05-31 23:17:02 UTC)
#6
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007133004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007133004/140001
3 years, 6 months ago
(2016-06-01 05:30:55 UTC)
#11
3 years, 6 months ago
(2016-06-01 05:35:07 UTC)
#12
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
commit-bot: I haz the power
Description was changed from ========== Disallow navigation to documents not explicitly listed as web accessible. ...
3 years, 6 months ago
(2016-06-01 05:36:18 UTC)
#13
Message was sent while issue was closed.
Description was changed from
==========
Disallow navigation to documents not explicitly listed as web accessible.
The existing check for web accessible resources is inadequate and allows
navigations to non-whitelisted pages to succeed. This patch ensures that
the document is listed explicitly in the manifest when a navigation is
performed to it.
BUG=576867
==========
to
==========
Disallow navigation to documents not explicitly listed as web accessible.
The existing check for web accessible resources is inadequate and allows
navigations to non-whitelisted pages to succeed. This patch ensures that
the document is listed explicitly in the manifest when a navigation is
performed to it.
BUG=576867
Committed: https://crrev.com/5cf9d45c437b7b2d899e46f2f324c147a2743eb7
Cr-Commit-Position: refs/heads/master@{#397066}
==========
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/5cf9d45c437b7b2d899e46f2f324c147a2743eb7 Cr-Commit-Position: refs/heads/master@{#397066}
3 years, 6 months ago
(2016-06-01 05:36:19 UTC)
#14
Issue 2007133004: Disallow navigation to documents not explicitly listed as web accessible.
(Closed)
Created 3 years, 6 months ago by nasko
Modified 3 years, 6 months ago
Reviewers: asargent_no_longer_on_chrome
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 6