Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 200713005: components: Rename encryptor directory to os_crypt. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
bcwhite, Lei Zhang, Jói
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, dyu1, benquan, tfarina, haitaol+watch_chromium.org, Dane Wallinga, browser-components-watch_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

components: Rename encryptor directory to os_crypt. Joi suggested doing this rename in a follow up CL ( https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16). So here it is. BUG=341293 TEST=None, no functional changes. R=joi@chromium.org,thestig@chromium.org,bcwhite@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -1234 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/logins_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_launcher_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 5 chunks +8 lines, -8 lines 0 comments Download
D components/encryptor.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D components/encryptor/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/encryptor/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/encryptor/README View 1 chunk +0 lines, -4 lines 0 comments Download
D components/encryptor/encryptor_switches.h View 1 chunk +0 lines, -26 lines 0 comments Download
D components/encryptor/encryptor_switches.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D components/encryptor/ie7_password_unittest_win.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D components/encryptor/ie7_password_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/encryptor/ie7_password_win.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D components/encryptor/keychain_password_mac.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/encryptor/keychain_password_mac.mm View 1 chunk +0 lines, -79 lines 0 comments Download
D components/encryptor/keychain_password_mac_unittest.mm View 1 chunk +0 lines, -80 lines 0 comments Download
D components/encryptor/os_crypt.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/encryptor/os_crypt_mac.mm View 1 chunk +0 lines, -155 lines 0 comments Download
D components/encryptor/os_crypt_posix.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D components/encryptor/os_crypt_unittest.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D components/encryptor/os_crypt_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
A + components/os_crypt.gypi View 2 chunks +14 lines, -14 lines 0 comments Download
A + components/os_crypt/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/os_crypt/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/os_crypt/README View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/os_crypt/ie7_password_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/os_crypt/ie7_password_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/ie7_password_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/keychain_password_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/os_crypt/keychain_password_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/keychain_password_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/os_crypt.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/os_crypt/os_crypt_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/os_crypt/os_crypt_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/os_crypt_switches.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/os_crypt/os_crypt_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/os_crypt/os_crypt_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/os_crypt_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M components/password_manager/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/signin/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/webdata/token_service_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/system_encryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/system_encryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/gcm.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 9 months ago (2014-03-16 03:51:41 UTC) #1
Jói
LGTM, thanks Thiago.
6 years, 9 months ago (2014-03-17 10:34:08 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-17 16:09:25 UTC) #3
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 9 months ago (2014-03-17 16:09:28 UTC) #4
Lei Zhang
lgtm
6 years, 9 months ago (2014-03-17 18:39:25 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-17 22:17:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/200713005/1
6 years, 9 months ago (2014-03-17 22:20:12 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 01:34:59 UTC) #8
Message was sent while issue was closed. 
Change committed as 257573

Powered by Google App Engine
This is Rietveld 408576698