service/datastore/key_test.go - Issue 2007123002: datastore: Update AllocateIDs to take keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/key_test.go

Issue 2007123002: datastore: Update AllocateIDs to take keys. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Rebase, comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: service/datastore/key_test.go

diff --git a/service/datastore/key_test.go b/service/datastore/key_test.go

index 686cb64877ac0bb28cc58888c81559c97fa4fe4f..ae8fe3c824e626a9663252625e377f2c04b1d3a2 100644

--- a/service/datastore/key_test.go

+++ b/service/datastore/key_test.go

@@ -105,8 +105,8 @@ func TestKeyValidity(t *testing.T) {

Convey("keys validity", t, func() {

Convey("incomplete", func() {

- So(MakeKey("aid", "ns", "kind", 1).Incomplete(), ShouldBeFalse)

- So(MakeKey("aid", "ns", "kind", 0).Incomplete(), ShouldBeTrue)

+ So(MakeKey("aid", "ns", "kind", 1).IsIncomplete(), ShouldBeFalse)

+ So(MakeKey("aid", "ns", "kind", 0).IsIncomplete(), ShouldBeTrue)

})

Convey("invalid", func() {

« no previous file with comments | « service/datastore/key.go ('k') | service/datastore/multiarg.go » ('j') | no next file with comments »