service/datastore/finalized_query.go - Issue 2007123002: datastore: Update AllocateIDs to take keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/finalized_query.go

Issue 2007123002: datastore: Update AllocateIDs to take keys. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Rebase, comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: service/datastore/finalized_query.go

diff --git a/service/datastore/finalized_query.go b/service/datastore/finalized_query.go

index c007b1ba4b1828a03cafe8767385f49c49eb81c6..cb1b525cec4fd0e79f60efc780b51cac896f2a68 100644

--- a/service/datastore/finalized_query.go

+++ b/service/datastore/finalized_query.go

@@ -323,7 +323,7 @@ func (q *FinalizedQuery) String() string {

// have values of type PTKey (but don't filter on the magic '__key__' field).

func (q *FinalizedQuery) Valid(aid, ns string) error {

anc := q.Ancestor()

- if anc != nil && (!anc.Valid(false, aid, ns) || anc.Incomplete()) {

+ if anc != nil && (!anc.Valid(false, aid, ns) || anc.IsIncomplete()) {

return ErrInvalidKey

}

« no previous file with comments | « service/datastore/datastore_test.go ('k') | service/datastore/interface.go » ('j') | no next file with comments »