Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2007113009: Revert of Memory Infra: Replace memory_health_plan with top_10_mobile (Closed)

Created:
4 years, 7 months ago by michaelbai
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Memory Infra: Replace memory_health_plan with top_10_mobile (patchset #5 id:80001 of https://codereview.chromium.org/1936533002/ ) Reason for revert: It seemed this broke the downstream bots https://uberchromegw.corp.google.com/i/internal.client.clank/builders/health-plan-clankium-low-end-phone/builds/858 Original issue's description: > Memory Infra: Replace memory_health_plan with top_10_mobile > > Replace memory.memory_health_plan with the memory.top_10_mobile > benchmark. > > This keeps the story to provide foreground/background measurements, > but swaps the page set to use top_10_mobile. > > New recordings are provided. > > Perf sheriffs warning: this is very likely to cause measurements in > memory.top_10_mobile to shift. > > BUG=606361 > > Committed: https://crrev.com/10ce2c477f580413bb34f26a0395c9c3bca5682a > Cr-Commit-Position: refs/heads/master@{#395876} TBR=petrcermak@chromium.org,sullivan@chromium.org,primiano@chromium.org,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606361 Committed: https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7 Cr-Commit-Position: refs/heads/master@{#395982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -142 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 2 chunks +8 lines, -15 lines 0 comments Download
A tools/perf/page_sets/data/memory_health_plan.json View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/memory_health_plan_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D tools/perf/page_sets/data/memory_top_10_mobile.json View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/perf/page_sets/data/memory_top_10_mobile_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A tools/perf/page_sets/memory_health_story.py View 1 chunk +106 lines, -0 lines 0 comments Download
D tools/perf/page_sets/memory_top_10_mobile.py View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
michaelbai
Created Revert of Memory Infra: Replace memory_health_plan with top_10_mobile
4 years, 7 months ago (2016-05-25 20:37:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007113009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007113009/1
4 years, 7 months ago (2016-05-25 20:37:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 20:38:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0b6e7a03576f8899ab9766f42781f654cd367d7 Cr-Commit-Position: refs/heads/master@{#395982}
4 years, 7 months ago (2016-05-25 20:40:06 UTC) #6
perezju
4 years, 7 months ago (2016-05-26 08:07:03 UTC) #7
Message was sent while issue was closed.
lgtm thanks

Powered by Google App Engine
This is Rietveld 408576698